Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decimal fallback for malformed PDFs. #387

Closed
wants to merge 2 commits into from
Closed

Decimal fallback for malformed PDFs. #387

wants to merge 2 commits into from

Conversation

jcampbell05
Copy link

Fixes #386

EdekiO
EdekiO reviewed Sep 16, 2019
View reviewed changes
Copy link

@EdekiO EdekiO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting a decimal.InvalidOperation: [<class 'decimal.ConversionSyntax'>] which was preventing me from downloading certain pdfs. However this fixed solved that error with no changes anywhere else in the codebank

@MartinThoma MartinThoma added is-bug From a users perspective, this is a bug - a violation of the expected behavior with a compliant PDF Tiny Pull requests that make a tiny change - and thus should be easy to merge is-robustness-issue From a users perspective, this is about robustness and removed is-bug From a users perspective, this is a bug - a violation of the expected behavior with a compliant PDF labels Apr 6, 2022
@MartinThoma MartinThoma mentioned this pull request Apr 7, 2022
Closed
@MartinThoma
Copy link
Member

@jcampbell05 Would you mind to open a new PR with only the changes in generic.py? That one I would merge immediately. I'm uncertain about the changes in pdf.py.

If you don't have the time for that, I would do it myself + add you as a co-author in the commit message to give you attribution.

@MartinThoma MartinThoma added soon PRs that are almost ready to be merged, issues that get solved pretty soon needs-change The PR/issue cannot be handled as issue and needs to be improved labels Apr 16, 2022
@jcampbell05
Copy link
Author

Hi @MartinThoma I am happy for you to take over and add me as co-author.

@MartinThoma
Copy link
Member

#782 was merged and will be part of the next release 👍

@MartinThoma
Copy link
Member

Closing here as this was merged in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdekiO EdekiO EdekiO left review comments

Assignees
No one assigned
Labels
is-robustness-issue From a users perspective, this is about robustness needs-change The PR/issue cannot be handled as issue and needs to be improved soon PRs that are almost ready to be merged, issues that get solved pretty soon Tiny Pull requests that make a tiny change - and thus should be easy to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InvalidOperation: Invalid Literal for Decimal '0.0000-74251147'
3 participants
@jcampbell05 @MartinThoma @EdekiO